fix: minor issues from code review

(M1) DTO: @IsObject({ each: true }) on dimensions array
(M2) audit log: add missing tenantId in submitAnswer
(M3) console.log -> this.logger in controller + service

server/src/assessment/assessment.controller.ts

@@ -13,6 +13,7 @@ import {
   Delete,
   Put,
   ForbiddenException,
+  Logger,
 } from '@nestjs/common';
 import { map } from 'rxjs/operators';
 import { AssessmentService } from './assessment.service';
@@ -26,6 +27,8 @@ import { ApiTags, ApiOperation, ApiResponse } from '@nestjs/swagger';
 @Controller('assessment')
 @UseGuards(CombinedAuthGuard)
 export class AssessmentController {
+  private readonly logger = new Logger(AssessmentController.name);
+
   constructor(
     private readonly assessmentService: AssessmentService,
     private readonly exportService: ExportService,
@@ -40,8 +43,8 @@ export class AssessmentController {
     body: { knowledgeBaseId?: string; language?: string; templateId?: string },
   ) {
     const { id: userId, tenantId } = req.user;
-    console.log(
-      `[AssessmentController] startSession: user=${userId}, tenant=${tenantId}, templateId=${body.templateId}, kbId=${body.knowledgeBaseId}`,
+    this.logger.log(
+      `startSession: user=${userId}, tenant=${tenantId}, templateId=${body.templateId}, kbId=${body.knowledgeBaseId}`,
     );
     const session = await this.assessmentService.startSession(
       userId,
@@ -61,9 +64,9 @@ export class AssessmentController {
     @Param('id') sessionId: string,
     @Body() body: { answer: string; language?: string },
   ) {
-    const { id: userId } = req.user;
-    console.log(
-      `[AssessmentController] >>> submitAnswer CALLED: user=${userId}, session=${sessionId}, answerLen=${body.answer?.length}`,
+    const { id: userId, tenantId } = req.user;
+    this.logger.log(
+      `submitAnswer: user=${userId}, session=${sessionId}, answerLen=${body.answer?.length}`,
     );
     const result = await this.assessmentService.submitAnswer(
       sessionId,
@@ -71,7 +74,7 @@ export class AssessmentController {
       body.answer,
       body.language,
     );
-    this.auditLog.log({ userId, action: 'session.answer', resourceType: 'assessment_session', resourceId: sessionId, details: { answerLength: body.answer?.length } });
+    this.auditLog.log({ userId, tenantId, action: 'session.answer', resourceType: 'assessment_session', resourceId: sessionId, details: { answerLength: body.answer?.length } });
     return result;
   }
 
@@ -79,8 +82,8 @@ export class AssessmentController {
   @ApiOperation({ summary: 'Stream initial session generation' })
   startSessionStream(@Request() req: any, @Param('id') sessionId: string) {
     const { id: userId } = req.user;
-    console.log(
-      `[AssessmentController] startSessionStream: user=${userId}, session=${sessionId}`,
+    this.logger.log(
+      `startSessionStream: user=${userId}, session=${sessionId}`,
     );
     return this.assessmentService
       .startSessionStream(sessionId, userId)
@@ -98,8 +101,8 @@ export class AssessmentController {
     @Query('language') language?: string,
   ) {
     const { id: userId } = req.user;
-    console.log(
-      `[AssessmentController] >>> submitAnswerStream CALLED: user=${userId}, session=${sessionId}, answerLen=${answer?.length}, lang=${language}`,
+    this.logger.log(
+      `submitAnswerStream: user=${userId}, session=${sessionId}, answerLen=${answer?.length}, lang=${language}`,
     );
     return this.assessmentService
       .submitAnswerStream(sessionId, userId, answer, language)
@@ -110,8 +113,8 @@ export class AssessmentController {
   @ApiOperation({ summary: 'Get the current state of an assessment session' })
   async getSessionState(@Request() req: any, @Param('id') sessionId: string) {
     const { id: userId } = req.user;
-    console.log(
-      `[AssessmentController] getSessionState: user=${userId}, session=${sessionId}`,
+    this.logger.log(
+      `getSessionState: user=${userId}, session=${sessionId}`,
     );
     return this.assessmentService.getSessionState(sessionId, userId);
   }
@@ -120,8 +123,8 @@ export class AssessmentController {
   @ApiOperation({ summary: 'Delete an assessment session' })
   async deleteSession(@Request() req: any, @Param('id') sessionId: string) {
     const user = req.user;
-    console.log(
-      `[AssessmentController] deleteSession: user=${user.id}, role=${user.role}, session=${sessionId}`,
+    this.logger.log(
+      `deleteSession: user=${user.id}, role=${user.role}, session=${sessionId}`,
     );
     await this.assessmentService.deleteSession(sessionId, user);
     this.auditLog.log({ userId: user.id, tenantId: user.tenantId, action: 'session.delete', resourceType: 'assessment_session', resourceId: sessionId });
@@ -135,8 +138,8 @@ export class AssessmentController {
     @Param('id') sessionId: string,
   ) {
     const { id: userId, tenantId } = req.user;
-    console.log(
-      `[AssessmentController] getCertificate: user=${userId}, session=${sessionId}`,
+    this.logger.log(
+      `getCertificate: user=${userId}, session=${sessionId}`,
     );
     return this.assessmentService.generateCertificate(sessionId, userId, tenantId);
   }
@@ -178,8 +181,8 @@ export class AssessmentController {
     @Query('knowledgeGroupId') knowledgeGroupId?: string,
   ) {
     const { id: userId, tenantId, role } = req.user;
-    console.log(
-      `[AssessmentController] getStats: user=${userId}, role=${role}, tenant=${tenantId}`,
+    this.logger.log(
+      `getStats: user=${userId}, role=${role}, tenant=${tenantId}`,
     );
     return this.assessmentService.getStats(
       userId,