alexey.rassokhin/tet123
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

DBZ-7811 Reduce logging level for invalid timestamp/date values, fix edge case

Browse Source
This commit is contained in:
twthorn 2024-04-23 16:17:30 -05:00 committed by Jiri Pechanec
parent 7779bb1a95
commit e356c0a06c
2 changed files with 118 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
debezium-connector-binlog/src/main/java/io/debezium/connector/binlog/jdbc/BinlogValueConverters.java
View File

@ -900,8 +900,8 @@ public static LocalDate stringToLocalDate(String dateString, Column column, Tabl
final int month = Integer.parseInt(matcher.group(2));
final int day = Integer.parseInt(matcher.group(3));
if (year == 0 || month == 0 || day == 0) {
LOGGER.warn("Invalid value '{}' stored in column '{}' of table '{}' converted to empty value",
if (month == 0 || day == 0) {
LOGGER.debug("Invalid value '{}' stored in column '{}' of table '{}' converted to empty value",
dateString, column.name(), table.id());
return null;
}
@ -927,8 +927,8 @@ public static boolean containsZeroValuesInDatePart(String timestampString, Colum
final int month = Integer.parseInt(matcher.group(2));
final int day = Integer.parseInt(matcher.group(3));
if (year == 0 || month == 0 || day == 0) {
LOGGER.warn("Invalid value '{}' stored in column '{}' of table '{}' converted to empty value",
if (month == 0 || day == 0) {
LOGGER.debug("Invalid value '{}' stored in column '{}' of table '{}' converted to empty value",
timestampString, column.name(), table.id());
return true;
}

114
debezium-connector-binlog/src/test/java/io/debezium/connector/binlog/BinlogValueConvertersTest.java
View File

@ -6,9 +6,11 @@
package io.debezium.connector.binlog;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.junit.Assert.assertEquals;
import java.math.BigDecimal;
import java.sql.Timestamp;
import java.time.LocalDate;
import java.time.LocalDateTime;
import java.time.Month;
@ -265,6 +267,118 @@ public void testZonedDateTimeWithMicrosecondPrecision() {
assertEquals("2023-01-11T00:34:10Z", colDConverter.convert(ZonedDateTime.parse("2023-01-11T00:34:10Z")));
}
@Test
public void testInvalidLocalDate() {
LogInterceptor interceptor = new LogInterceptor(BinlogValueConverters.class);
String dateTable = "DATE_TABLE";
String sql = "CREATE TABLE " + dateTable + " (A DATE NOT NULL);";
final BinlogValueConverters converters = getValueConverters(
JdbcValueConverters.DecimalMode.PRECISE,
TemporalPrecisionMode.ADAPTIVE_TIME_MICROSECONDS,
JdbcValueConverters.BigIntUnsignedMode.LONG,
BinaryHandlingMode.BYTES,
x -> x,
EventConvertingFailureHandlingMode.WARN);
DdlParser parser = getDdlParser();
Tables tables = new Tables();
parser.parse(sql, tables);
Table table = tables.forTable(new TableId(null, null, dateTable));
Column colA = table.columnWithName("A");
LocalDate actual = BinlogValueConverters.stringToLocalDate("0000-00-00", colA, table);
assertThat(actual).isNull();
assertThat(interceptor.containsWarnMessage("Invalid value")).isFalse();
}
@Test
public void testDateValidYear() {
String dateTable = "DATE_TABLE";
String sql = "CREATE TABLE " + dateTable + " (A DATE NOT NULL);";
final BinlogValueConverters converters = getValueConverters(
JdbcValueConverters.DecimalMode.PRECISE,
TemporalPrecisionMode.ADAPTIVE_TIME_MICROSECONDS,
JdbcValueConverters.BigIntUnsignedMode.LONG,
BinaryHandlingMode.BYTES,
x -> x,
EventConvertingFailureHandlingMode.WARN);
DdlParser parser = getDdlParser();
Tables tables = new Tables();
parser.parse(sql, tables);
Table table = tables.forTable(new TableId(null, null, dateTable));
Column colA = table.columnWithName("A");
LocalDate actual = BinlogValueConverters.stringToLocalDate("0000-01-01", colA, table);
assertThat(actual).isEqualTo(LocalDate.of(0, 1, 1));
}
@Test
public void testInvalidTimestamp() {
LogInterceptor interceptor = new LogInterceptor(BinlogValueConverters.class);
String dateTable = "TIMESTAMP_TABLE";
String sql = "CREATE TABLE " + dateTable + " (A TIMESTAMP(3) NOT NULL);";
final BinlogValueConverters converters = getValueConverters(
JdbcValueConverters.DecimalMode.PRECISE,
TemporalPrecisionMode.ADAPTIVE_TIME_MICROSECONDS,
JdbcValueConverters.BigIntUnsignedMode.LONG,
BinaryHandlingMode.BYTES,
x -> x,
EventConvertingFailureHandlingMode.WARN);
DdlParser parser = getDdlParser();
Tables tables = new Tables();
parser.parse(sql, tables);
Table table = tables.forTable(new TableId(null, null, dateTable));
Column colA = table.columnWithName("A");
String timestampString = "0000-00-00 00:00:00.000";
assertThatThrownBy(() -> {
Timestamp.valueOf(timestampString);
}).isInstanceOf(RuntimeException.class);
Boolean actual = BinlogValueConverters.containsZeroValuesInDatePart(timestampString, colA, table);
assertThat(actual).isTrue();
assertThat(interceptor.containsWarnMessage("Invalid value")).isFalse();
}
@Test
public void testTimestampValidYear() {
String dateTable = "TIMESTAMP_TABLE";
String sql = "CREATE TABLE " + dateTable + " (A TIMESTAMP(3) NOT NULL);";
final BinlogValueConverters converters = getValueConverters(
JdbcValueConverters.DecimalMode.PRECISE,
TemporalPrecisionMode.ADAPTIVE_TIME_MICROSECONDS,
JdbcValueConverters.BigIntUnsignedMode.LONG,
BinaryHandlingMode.BYTES,
x -> x,
EventConvertingFailureHandlingMode.WARN);
DdlParser parser = getDdlParser();
Tables tables = new Tables();
parser.parse(sql, tables);
Table table = tables.forTable(new TableId(null, null, dateTable));
Column colA = table.columnWithName("A");
String timestampString = "0000-01-01 00:00:00.000";
assertThat(Timestamp.valueOf(timestampString)).isNotNull();
Boolean actual = BinlogValueConverters.containsZeroValuesInDatePart(timestampString, colA, table);
assertThat(actual).isFalse();
}
protected LocalDate localDateWithYear(int year) {
return LocalDate.of(year, Month.APRIL, 4);
}