From d374ca0464221b10d10570b0c68143e2cff34102 Mon Sep 17 00:00:00 2001 From: Andreas Bergmeier Date: Thu, 21 Jun 2018 16:48:19 +0200 Subject: [PATCH] DBZ-759 Fix ColumnImpl.scale equality check According to ErrorProne, checking Optional via operator == leads to reference equality check. Probably want rather to check for contained values. --- .../src/main/java/io/debezium/relational/ColumnImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debezium-core/src/main/java/io/debezium/relational/ColumnImpl.java b/debezium-core/src/main/java/io/debezium/relational/ColumnImpl.java index b96e1b617..36d83fd7a 100644 --- a/debezium-core/src/main/java/io/debezium/relational/ColumnImpl.java +++ b/debezium-core/src/main/java/io/debezium/relational/ColumnImpl.java @@ -145,7 +145,7 @@ public boolean equals(Object obj) { Strings.equalsIgnoreCase(this.charsetName(),that.charsetName()) && this.position() == that.position() && this.length() == that.length() && - this.scale() == that.scale() && + this.scale().equals(that.scale()) && this.isOptional() == that.isOptional() && this.isAutoIncremented() == that.isAutoIncremented() && this.isGenerated() == that.isGenerated() &&