diff --git a/debezium-connector-oracle/src/test/java/io/debezium/connector/oracle/OracleConnectorConfigTest.java b/debezium-connector-oracle/src/test/java/io/debezium/connector/oracle/OracleConnectorConfigTest.java index 8f161a407..fcdb4f9fd 100644 --- a/debezium-connector-oracle/src/test/java/io/debezium/connector/oracle/OracleConnectorConfigTest.java +++ b/debezium-connector-oracle/src/test/java/io/debezium/connector/oracle/OracleConnectorConfigTest.java @@ -7,12 +7,12 @@ import static org.junit.Assert.assertFalse; import static org.junit.Assert.assertTrue; + import org.junit.Test; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import io.debezium.config.Configuration; -import io.debezium.connector.oracle.util.TestHelper; public class OracleConnectorConfigTest { @@ -23,12 +23,12 @@ public void validXtreamNoUrl() throws Exception { final OracleConnectorConfig connectorConfig = new OracleConnectorConfig( Configuration.create() - .with(OracleConnectorConfig.SERVER_NAME, "myserver") - .with(OracleConnectorConfig.HOSTNAME, "MyHostname") - .with(OracleConnectorConfig.DATABASE_NAME, "mydb") - .with(OracleConnectorConfig.XSTREAM_SERVER_NAME, "myserver") - .with(OracleConnectorConfig.USER, "debezium") - .build()); + .with(OracleConnectorConfig.SERVER_NAME, "myserver") + .with(OracleConnectorConfig.HOSTNAME, "MyHostname") + .with(OracleConnectorConfig.DATABASE_NAME, "mydb") + .with(OracleConnectorConfig.XSTREAM_SERVER_NAME, "myserver") + .with(OracleConnectorConfig.USER, "debezium") + .build()); assertTrue(connectorConfig.getConfig().validateAndRecord(connectorConfig.ALL_FIELDS, LOGGER::error)); } @@ -37,13 +37,13 @@ public void validLogminerNoUrl() throws Exception { final OracleConnectorConfig connectorConfig = new OracleConnectorConfig( Configuration.create() - .with(OracleConnectorConfig.CONNECTOR_ADAPTER, "logminer") - .with(OracleConnectorConfig.SERVER_NAME, "myserver") - .with(OracleConnectorConfig.HOSTNAME, "MyHostname") - .with(OracleConnectorConfig.DATABASE_NAME, "mydb") - .with(OracleConnectorConfig.SCHEMA_NAME, "myschema") - .with(OracleConnectorConfig.USER, "debezium") - .build()); + .with(OracleConnectorConfig.CONNECTOR_ADAPTER, "logminer") + .with(OracleConnectorConfig.SERVER_NAME, "myserver") + .with(OracleConnectorConfig.HOSTNAME, "MyHostname") + .with(OracleConnectorConfig.DATABASE_NAME, "mydb") + .with(OracleConnectorConfig.SCHEMA_NAME, "myschema") + .with(OracleConnectorConfig.USER, "debezium") + .build()); assertTrue(connectorConfig.getConfig().validateAndRecord(connectorConfig.ALL_FIELDS, LOGGER::error)); } @@ -52,12 +52,12 @@ public void validXtreamWithUrl() throws Exception { final OracleConnectorConfig connectorConfig = new OracleConnectorConfig( Configuration.create() - .with(OracleConnectorConfig.SERVER_NAME, "myserver") - .with(OracleConnectorConfig.URL, "jdbc:oci:thin:@myserver/mydatabase") - .with(OracleConnectorConfig.DATABASE_NAME, "mydb") - .with(OracleConnectorConfig.XSTREAM_SERVER_NAME, "myserver") - .with(OracleConnectorConfig.USER, "debezium") - .build()); + .with(OracleConnectorConfig.SERVER_NAME, "myserver") + .with(OracleConnectorConfig.URL, "jdbc:oci:thin:@myserver/mydatabase") + .with(OracleConnectorConfig.DATABASE_NAME, "mydb") + .with(OracleConnectorConfig.XSTREAM_SERVER_NAME, "myserver") + .with(OracleConnectorConfig.USER, "debezium") + .build()); assertTrue(connectorConfig.getConfig().validateAndRecord(connectorConfig.ALL_FIELDS, LOGGER::error)); } @@ -66,43 +66,43 @@ public void validLogminerWithUrl() throws Exception { final OracleConnectorConfig connectorConfig = new OracleConnectorConfig( Configuration.create() - .with(OracleConnectorConfig.CONNECTOR_ADAPTER, "logminer") - .with(OracleConnectorConfig.SERVER_NAME, "myserver") - .with(OracleConnectorConfig.URL, "MyHostname") - .with(OracleConnectorConfig.DATABASE_NAME, "mydb") - .with(OracleConnectorConfig.SCHEMA_NAME, "myschema") - .with(OracleConnectorConfig.USER, "debezium") - .build()); + .with(OracleConnectorConfig.CONNECTOR_ADAPTER, "logminer") + .with(OracleConnectorConfig.SERVER_NAME, "myserver") + .with(OracleConnectorConfig.URL, "MyHostname") + .with(OracleConnectorConfig.DATABASE_NAME, "mydb") + .with(OracleConnectorConfig.SCHEMA_NAME, "myschema") + .with(OracleConnectorConfig.USER, "debezium") + .build()); assertTrue(connectorConfig.getConfig().validateAndRecord(connectorConfig.ALL_FIELDS, LOGGER::error)); - } + } @Test public void validUrlTNS() throws Exception { final OracleConnectorConfig connectorConfig = new OracleConnectorConfig( Configuration.create() - .with(OracleConnectorConfig.CONNECTOR_ADAPTER, "logminer") - .with(OracleConnectorConfig.SERVER_NAME, "myserver") - .with(OracleConnectorConfig.URL, "jdbc:oracle:thin:@(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=192.68.1.11)(PORT=1701))(ADDRESS=(PROTOCOL=TCP)(HOST=192.68.1.12)(PORT=1701))(ADDRESS=(PROTOCOL=TCP)(HOST=192.68.1.13)(PORT=1701))(LOAD_BALANCE = yes)(FAILOVER = on)(CONNECT_DATA =(SERVER = DEDICATED)(SERVICE_NAME = myserver.mydomain.com)(FAILOVER_MODE =(TYPE = SELECT)(METHOD = BASIC)(RETRIES = 3)(DELAY = 5))))") - .with(OracleConnectorConfig.DATABASE_NAME, "mydb") - .with(OracleConnectorConfig.SCHEMA_NAME, "myschema") - .with(OracleConnectorConfig.USER, "debezium") - .build()); + .with(OracleConnectorConfig.CONNECTOR_ADAPTER, "logminer") + .with(OracleConnectorConfig.SERVER_NAME, "myserver") + .with(OracleConnectorConfig.URL, + "jdbc:oracle:thin:@(DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=192.68.1.11)(PORT=1701))(ADDRESS=(PROTOCOL=TCP)(HOST=192.68.1.12)(PORT=1701))(ADDRESS=(PROTOCOL=TCP)(HOST=192.68.1.13)(PORT=1701))(LOAD_BALANCE = yes)(FAILOVER = on)(CONNECT_DATA =(SERVER = DEDICATED)(SERVICE_NAME = myserver.mydomain.com)(FAILOVER_MODE =(TYPE = SELECT)(METHOD = BASIC)(RETRIES = 3)(DELAY = 5))))") + .with(OracleConnectorConfig.DATABASE_NAME, "mydb") + .with(OracleConnectorConfig.SCHEMA_NAME, "myschema") + .with(OracleConnectorConfig.USER, "debezium") + .build()); assertTrue(connectorConfig.getConfig().validateAndRecord(connectorConfig.ALL_FIELDS, LOGGER::error)); } - @Test public void invalidNoHostnameNoUri() throws Exception { final OracleConnectorConfig connectorConfig = new OracleConnectorConfig( Configuration.create() - .with(OracleConnectorConfig.CONNECTOR_ADAPTER, "logminer") - .with(OracleConnectorConfig.SERVER_NAME, "myserver") - .with(OracleConnectorConfig.DATABASE_NAME, "mydb") - .with(OracleConnectorConfig.SCHEMA_NAME, "myschema") - .with(OracleConnectorConfig.USER, "debezium") - .build()); + .with(OracleConnectorConfig.CONNECTOR_ADAPTER, "logminer") + .with(OracleConnectorConfig.SERVER_NAME, "myserver") + .with(OracleConnectorConfig.DATABASE_NAME, "mydb") + .with(OracleConnectorConfig.SCHEMA_NAME, "myschema") + .with(OracleConnectorConfig.USER, "debezium") + .build()); assertFalse(connectorConfig.getConfig().validateAndRecord(connectorConfig.ALL_FIELDS, LOGGER::error)); - } + } }