alexey.rassokhin/tet123
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

DBZ-6249 Fix error thrown when snapshot.custom_class=custom and no snapshot.custom.class

Browse Source
This commit is contained in:
Nir Levy 2023-03-23 17:58:54 +02:00 committed by Jiri Pechanec
parent 84ab0dc3d2
commit c7e00d3881
2 changed files with 30 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
debezium-connector-postgres/src/main/java/io/debezium/connector/postgresql/PostgresConnectorConfig.java
View File

@ -711,7 +711,7 @@ public static AutoCreateMode parse(String value, String defaultValue) {
.withWidth(Width.MEDIUM)
.withImportance(Importance.MEDIUM)
.withValidation((config, field, output) -> {
if (config.getString(SNAPSHOT_MODE).toLowerCase().equals("custom") && config.getString(field).isEmpty()) {
if (config.getString(SNAPSHOT_MODE).toLowerCase().equals("custom") && config.getString(field, "").isEmpty()) {
output.accept(field, "", "snapshot.custom_class cannot be empty when snapshot.mode 'custom' is defined");
return 1;
}

29
debezium-connector-postgres/src/test/java/io/debezium/connector/postgresql/PostgresConnectorIT.java
View File

@ -14,6 +14,7 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotEquals;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
@ -34,6 +35,7 @@
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.concurrent.atomic.AtomicReference;
import java.util.function.Predicate;
import java.util.stream.IntStream;
@ -3187,6 +3189,33 @@ public void shouldInvokeSnapshotterAbortedMethod() throws Exception {
}
}
@Test
@FixFor("DBZ-6249")
public void shouldThrowRightExceptionWhenNoCustomSnapshotClassProvided() {
AtomicReference<Throwable> error = new AtomicReference<>();
AtomicReference<String> message = new AtomicReference<>();
AtomicReference<Boolean> status = new AtomicReference<>();
AtomicBoolean finished = new AtomicBoolean(false);
Configuration config = TestHelper.defaultConfig()
.with(PostgresConnectorConfig.SNAPSHOT_MODE, SnapshotMode.CUSTOM.getValue())
.build();
start(PostgresConnector.class, config, (success, msg, err) -> {
error.set(err);
message.set(msg);
status.set(success);
finished.set(true);
});
Awaitility.await()
.pollInterval(100, TimeUnit.MILLISECONDS)
.atMost(waitTimeForRecords() * 30L, TimeUnit.SECONDS)
.until(() -> finished.get());
assertThat(status.get()).isFalse();
assertNull(error.get());
assertThat(message.get()).contains("snapshot.custom_class cannot be empty when snapshot.mode 'custom' is defined");
}
@FixFor("DBZ-5917")
public void shouldIncludeTableWithBackSlashInName() throws Exception {
String setupStmt = "DROP SCHEMA IF EXISTS s1 CASCADE;" +