DBZ-1722 Addressing review remarks

This commit is contained in:
Gunnar Morling 2020-02-11 14:06:12 +01:00
parent 965ff009a8
commit 711d55e836
3 changed files with 16 additions and 11 deletions

View File

@ -12,6 +12,7 @@ env:
- MAVEN_CLI: '"clean install -B -pl debezium-connector-mongodb -am -Passembly -Dformat.formatter.goal=validate -Dformat.imports.goal=check"'
- MAVEN_CLI: '"clean install -B -pl debezium-connector-mongodb -am -Passembly -Dformat.formatter.goal=validate -Dformat.imports.goal=check -Dversion.mongo.server=4.0"'
- MAVEN_CLI: '"clean install -B -pl debezium-quarkus-outbox -am -amd -Passembly -Dformat.formatter.goal=validate -Dformat.imports.goal=check"'
- MAVEN_CLI: '"clean install -B -pl debezium-testing -am -amd -Passembly -Dformat.formatter.goal=validate -Dformat.imports.goal=check"'
sudo: required

View File

@ -5,6 +5,7 @@
*/
package io.debezium.testing.testcontainers;
import java.util.Collections;
import java.util.HashMap;
import java.util.Map;
@ -13,23 +14,27 @@
*/
public class ConnectorResolver {
private static final Map<String, String> driverConnector = new HashMap<>();
private static final Map<String, String> CONNECTORS_BY_DRIVER;
static {
driverConnector.put("org.postgresql.Driver", "io.debezium.connector.postgresql.PostgresConnector");
driverConnector.put("com.mysql.cj.jdbc.Driver", "io.debezium.connector.mysql.MySqlConnector");
driverConnector.put("com.mysql.jdbc.Driver", "io.debezium.connector.mysql.MySqlConnector");
driverConnector.put("com.microsoft.sqlserver.jdbc.SQLServerDriver",
Map<String, String> tmp = new HashMap<>();
tmp.put("org.postgresql.Driver", "io.debezium.connector.postgresql.PostgresConnector");
tmp.put("com.mysql.cj.jdbc.Driver", "io.debezium.connector.mysql.MySqlConnector");
tmp.put("com.mysql.jdbc.Driver", "io.debezium.connector.mysql.MySqlConnector");
tmp.put("com.microsoft.sqlserver.jdbc.SQLServerDriver",
"io.debezium.connector.sqlserver.SqlServerConnector");
driverConnector.put("oracle.jdbc.OracleDriver", "io.debezium.connector.oracle.OracleConnector");
tmp.put("oracle.jdbc.OracleDriver", "io.debezium.connector.oracle.OracleConnector");
tmp.put("com.ibm.db2.jcc.DB2Driver", "io.debezium.connector.db2.Db2Connector");
CONNECTORS_BY_DRIVER = Collections.unmodifiableMap(tmp);
}
public static String getConnectorByJdbcDriver(String jdbcDriver) {
if (driverConnector.containsKey(jdbcDriver)) {
return driverConnector.get(jdbcDriver);
if (CONNECTORS_BY_DRIVER.containsKey(jdbcDriver)) {
return CONNECTORS_BY_DRIVER.get(jdbcDriver);
}
throw new IllegalArgumentException(String.format("%s JDBC driver is passed but only %s are supported.", jdbcDriver, driverConnector.keySet().toString()));
throw new IllegalArgumentException(String.format("%s JDBC driver is passed but only %s are supported.", jdbcDriver, CONNECTORS_BY_DRIVER.keySet().toString()));
}
}

View File

@ -149,7 +149,6 @@ private List<ConsumerRecord<String, String>> drain(KafkaConsumer<String, String>
private ConnectorConfiguration getConfiguration() {
// host, database, user etc. are obtained from the container
return ConnectorConfiguration.forJdbcContainer(postgresContainer)
.with("connector.class", "io.debezium.connector.postgresql.PostgresConnector")
.with("database.server.name", "dbserver1");
}