alexey.rassokhin/tet123
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

DBZ-453 Improving description of configuration option; also

Browse Source 
* some JavaDoc adjustments
* removing some dead code
This commit is contained in:
Gunnar Morling 2017-11-29 15:11:31 +01:00
parent 5dae38bfab
commit 4309164f27
3 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
debezium-connector-postgres/src/main/java/io/debezium/connector/postgresql/PostgresConnectorConfig.java
View File

@ -385,7 +385,9 @@ public String getValue() {
.withEnum(LogicalDecoder.class, LogicalDecoder.DECODERBUFS)
.withWidth(Width.MEDIUM)
.withImportance(Importance.MEDIUM)
.withDescription("The name of the Postgres logical decoding plugin installed on the server. Defaults to '"+ LogicalDecoder.DECODERBUFS.getValue() + "'");
.withDescription("The name of the Postgres logical decoding plugin installed on the server. " +
"Supported values are '"+ LogicalDecoder.DECODERBUFS.getValue() + "' and '"+ LogicalDecoder.WAL2JSON.getValue() + "'. " +
"Defaults to '"+ LogicalDecoder.DECODERBUFS.getValue() + "'.");
public static final Field SLOT_NAME = Field.create("slot.name")
.withDisplayName("Slot")

9
debezium-connector-postgres/src/main/java/io/debezium/connector/postgresql/connection/wal2json/Wal2JsonReplicationMessage.java
View File

@ -46,9 +46,6 @@ class Wal2JsonReplicationMessage implements ReplicationMessage {
private static final Logger LOGGER = LoggerFactory.getLogger(Wal2JsonReplicationMessage.class);
private static final Pattern TYPE_PATTERN = Pattern.compile("^(?<full>(?<base>[^(\\[]+)(?:\\((?<mod>.+)\\))?(?<suffix>.*?))(?<array>\\[\\])?$");
private static final Pattern TYPEMOD_PATTERN = Pattern.compile("\\s*,\\s*");
// "text"; "character varying(255)"; "numeric(12,3)"; "geometry(MultiPolygon,4326)"; "timestamp (12) with time zone"; "int[]"
private static final String[] NO_TYPE_MODIFIERS = {};
private final int txId;
private final long commitTime;
@ -172,10 +169,6 @@ public Object getValue(String columnName, String columnType, Value rawValue, fin
baseType = String.join(" ", baseType, m.group("suffix").trim());
}
String[] typeModifiers = NO_TYPE_MODIFIERS;
if (m.group("mod") != null) {
typeModifiers = TYPEMOD_PATTERN.split(m.group("mod")); // TODO: use for decimal/etc precision
}
boolean isArray = (m.group("array") != null);
if (baseType.startsWith("_")) {
@ -268,6 +261,8 @@ public Object getValue(String columnName, String columnType, Value rawValue, fin
return Strings.hexStringToByteArray(rawValue.asString());
// these are all PG-specific types and we use the JDBC representations
// note that, with the exception of point, no converters for these types are implemented yet,
// i.e. those values won't actually be propagated to the outbound message until that's the case
case "box":
try {
return new PGbox(rawValue.asString());

1
debezium-connector-postgres/src/test/java/io/debezium/connector/postgresql/RecordsStreamProducerIT.java
View File

@ -112,6 +112,7 @@ public void shouldReceiveChangesForInsertsWithDifferentDataTypes() throws Except
@Test
@ShouldFailWhen(DecoderDifferences.AreQuotedIdentifiersUnsupported.class)
// TODO DBZ-493
public void shouldReceiveChangesForInsertsWithQuotedNames() throws Exception {
TestHelper.executeDDL("postgres_create_tables.ddl");