alexey.rassokhin/tet123
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

DBZ-582 Avoiding assignment to test class field from test methods

Browse Source
This commit is contained in:
Gunnar Morling 2018-02-13 09:29:51 +01:00 committed by Jiri Pechanec
parent 5491b2775e
commit 39e08b7ec6
2 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
debezium-connector-mongodb/src/test/java/io/debezium/connector/mongodb/RecordMakersTest.java
View File

@ -12,7 +12,6 @@
import java.util.Calendar;
import java.util.List;
import io.debezium.doc.FixFor;
import org.apache.kafka.connect.data.Struct;
import org.apache.kafka.connect.source.SourceRecord;
import org.bson.BsonTimestamp;
@ -30,6 +29,7 @@
import io.debezium.connector.mongodb.RecordMakers.RecordsForCollection;
import io.debezium.data.Envelope.FieldName;
import io.debezium.data.Envelope.Operation;
import io.debezium.doc.FixFor;
/**
* @author Randall Hauch
@ -168,7 +168,7 @@ public void shouldGenerateRecordForDeleteEvent() throws InterruptedException {
@Test
@FixFor("DBZ-582")
public void shouldGenerateRecordForDeleteEventWithoutTombstone() throws InterruptedException {
RecordMakers recordMakersTemp = recordMakers = new RecordMakers(source, topicSelector, produced::add, false);
RecordMakers recordMakers = new RecordMakers(source, topicSelector, produced::add, false);
BsonTimestamp ts = new BsonTimestamp(1000, 1);
CollectionId collectionId = new CollectionId("rs0", "dbA", "c1");
@ -179,7 +179,7 @@ public void shouldGenerateRecordForDeleteEventWithoutTombstone() throws Interrup
.append("ts", ts)
.append("h", new Long(12345678))
.append("op", "d");
RecordsForCollection records = recordMakersTemp.forCollection(collectionId);
RecordsForCollection records = recordMakers.forCollection(collectionId);
records.recordEvent(event, 1002);
assertThat(produced.size()).isEqualTo(1);
@ -196,7 +196,6 @@ public void shouldGenerateRecordForDeleteEventWithoutTombstone() throws Interrup
Struct actualSource = value.getStruct(FieldName.SOURCE);
Struct expectedSource = source.lastOffsetStruct("rs0", collectionId);
assertThat(actualSource).isEqualTo(expectedSource);
}
@Test

16
debezium-connector-mongodb/src/test/java/io/debezium/connector/mongodb/transforms/UnwrapFromMongoDbEnvelopeTest.java
View File

@ -11,11 +11,7 @@
import java.util.Arrays;
import java.util.Collections;
import java.util.List;
import io.debezium.connector.mongodb.CollectionId;
import io.debezium.connector.mongodb.RecordMakers;
import io.debezium.connector.mongodb.SourceInfo;
import io.debezium.connector.mongodb.TopicSelector;
import io.debezium.doc.FixFor;
import org.apache.kafka.connect.data.SchemaBuilder;
import org.apache.kafka.connect.data.Struct;
import org.apache.kafka.connect.source.SourceRecord;
@ -26,7 +22,12 @@
import org.junit.Before;
import org.junit.Test;
import io.debezium.connector.mongodb.CollectionId;
import io.debezium.connector.mongodb.RecordMakers;
import io.debezium.connector.mongodb.RecordMakers.RecordsForCollection;
import io.debezium.connector.mongodb.SourceInfo;
import io.debezium.connector.mongodb.TopicSelector;
import io.debezium.doc.FixFor;
/**
* Unit test for {@link UnwrapFromMongoDbEnvelope}. It uses {@link RecordMakers}
@ -44,7 +45,6 @@ public class UnwrapFromMongoDbEnvelopeTest {
private RecordMakers recordMakers;
private TopicSelector topicSelector;
private List<SourceRecord> produced;
private boolean emitTombstonesOnDelete;
private UnwrapFromMongoDbEnvelope<SourceRecord> transformation;
@ -203,7 +203,7 @@ public void shouldGenerateRecordForUpdateEvent() throws InterruptedException {
@Test
@FixFor("DBZ-582")
public void shouldGenerateRecordForDeleteEventWithoutTombstone() throws InterruptedException {
RecordMakers recordMakersTemp = recordMakers = new RecordMakers(source, topicSelector, produced::add, false);
RecordMakers recordMakers = new RecordMakers(source, topicSelector, produced::add, false);
BsonTimestamp ts = new BsonTimestamp(1000, 1);
CollectionId collectionId = new CollectionId("rs0", "dbA", "c1");
@ -216,7 +216,7 @@ public void shouldGenerateRecordForDeleteEventWithoutTombstone() throws Interrup
.append("ts", ts)
.append("h", Long.valueOf(12345678))
.append("op", "d");
RecordsForCollection records = recordMakersTemp.forCollection(collectionId);
RecordsForCollection records = recordMakers.forCollection(collectionId);
records.recordEvent(event, 1002);
assertThat(produced.size()).isEqualTo(1);