alexey.rassokhin/tet123
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

DBZ-3482 Parse timestamps with short form for months with locale "en"

Browse Source
This commit is contained in:
Thomas Aregger 2021-05-17 20:37:27 +02:00 committed by Chris Cranford
parent 0027eb9f9c
commit 2d87fa9b3d
2 changed files with 28 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
debezium-connector-oracle/src/main/java/io/debezium/connector/oracle/OracleValueConverters.java
View File

@ -20,6 +20,7 @@
import java.time.format.DateTimeFormatter;
import java.time.format.DateTimeFormatterBuilder;
import java.time.temporal.ChronoField;
import java.util.Locale;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
@ -76,7 +77,7 @@ public class OracleValueConverters extends JdbcValueConverters {
.appendFraction(ChronoField.NANO_OF_SECOND, 0, 9, false)
.optionalEnd()
.appendPattern(" a")
.toFormatter();
.toFormatter(Locale.ENGLISH);
private static final DateTimeFormatter TIMESTAMP_TZ_FORMATTER = new DateTimeFormatterBuilder()
.parseCaseInsensitive()

42
debezium-connector-oracle/src/test/java/io/debezium/connector/oracle/logminer/OracleDmlParserTest.java
View File

@ -13,6 +13,7 @@
import java.util.Arrays;
import java.util.Iterator;
import java.util.List;
import java.util.Locale;
import java.util.stream.Collectors;
import org.apache.commons.lang3.StringUtils;
@ -102,23 +103,32 @@ public void shouldParseAliasUpdate() throws Exception {
@Test
public void shouldParseTimestampFormats() throws Exception {
String createStatement = IoUtil.read(IoUtil.getResourceAsStream("ddl/create_table.sql", null, getClass(), null, null));
ddlParser.parse(createStatement, tables);
String format1 = "TO_TIMESTAMP('2020-09-22 00:09:37.302000')";
String format2 = "TO_TIMESTAMP('2020-09-22 00:09:37.')";
String format3 = "TO_TIMESTAMP('2020-09-22 00:09:37')";
String format4 = "TO_TIMESTAMP('22-SEP-20 12.09.37 AM')";
String format5 = "TO_TIMESTAMP('22-SEP-20 12.09.37 PM')";
String format6 = "TO_TIMESTAMP('29-SEP-20 06.02.24.777000 PM')";
String format7 = "TO_TIMESTAMP('2020-09-22 00:09:37.0')";
Locale defaultLocale = Locale.getDefault();
try {
String createStatement = IoUtil.read(IoUtil.getResourceAsStream("ddl/create_table.sql", null, getClass(), null, null));
ddlParser.parse(createStatement, tables);
String format1 = "TO_TIMESTAMP('2020-09-22 00:09:37.302000')";
String format2 = "TO_TIMESTAMP('2020-09-22 00:09:37.')";
String format3 = "TO_TIMESTAMP('2020-09-22 00:09:37')";
String format4 = "TO_TIMESTAMP('22-SEP-20 12.09.37 AM')";
String format5 = "TO_TIMESTAMP('22-SEP-20 12.09.37 PM')";
String format6 = "TO_TIMESTAMP('29-SEP-20 06.02.24.777000 PM')";
String format7 = "TO_TIMESTAMP('2020-09-22 00:09:37.0')";
parseTimestamp(format1, false);
parseTimestamp(format2, true);
parseTimestamp(format3, true);
parseTimestamp(format4, true);
parseTimestamp(format5, false);
parseTimestamp(format6, false);
parseTimestamp(format7, true);
parseTimestamp(format1, false);
parseTimestamp(format2, true);
parseTimestamp(format3, true);
// Change to locale that does not recognize SEP in pattern MMM
Locale.setDefault(Locale.GERMAN);
parseTimestamp(format4, true);
parseTimestamp(format5, false);
parseTimestamp(format6, false);
Locale.setDefault(defaultLocale);
parseTimestamp(format7, true);
}
finally {
Locale.setDefault(defaultLocale);
}
}
@Test