alexey.rassokhin/tet123
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

DBZ-5045 Remove deprecated Postgres EXPORTED snapshot option

Browse Source
This commit is contained in:
Vojtech Juranek 2022-06-02 12:34:19 +02:00 committed by Jiri Pechanec
parent 83dfd9f638
commit 1eacbdc590
2 changed files with 4 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
debezium-connector-postgres/src/main/java/io/debezium/connector/postgresql/PostgresConnectorConfig.java
View File

@ -8,10 +8,8 @@
import java.time.Duration;
import java.util.Arrays;
import java.util.EnumSet;
import java.util.List;
import java.util.Map;
import java.util.stream.Collectors;
import org.apache.kafka.common.config.ConfigDef;
import org.apache.kafka.common.config.ConfigDef.Importance;
@ -39,7 +37,6 @@
import io.debezium.connector.postgresql.snapshot.InitialSnapshotter;
import io.debezium.connector.postgresql.snapshot.NeverSnapshotter;
import io.debezium.connector.postgresql.spi.Snapshotter;
import io.debezium.data.Envelope;
import io.debezium.jdbc.JdbcConfiguration;
import io.debezium.relational.ColumnFilterMode;
import io.debezium.relational.RelationalDatabaseConnectorConfig;
@ -203,12 +200,6 @@ public enum SnapshotMode implements EnumeratedValue {
*/
INITIAL_ONLY("initial_only", (c) -> new InitialOnlySnapshotter()),
/**
* Perform an exported snapshot
*/
@Deprecated
EXPORTED("exported", (c) -> new InitialSnapshotter()),
/**
* Inject a custom snapshotter, which allows for more control over snapshots.
*/
@ -704,13 +695,6 @@ public static AutoCreateMode parse(String value, String defaultValue) {
.withEnum(SnapshotMode.class, SnapshotMode.INITIAL)
.withWidth(Width.SHORT)
.withImportance(Importance.MEDIUM)
.withValidation((config, field, output) -> {
if (config.getString(field).toLowerCase().equals(SnapshotMode.EXPORTED.getValue())) {
LOGGER.warn("Value '{}' of 'snapshot.mode' option is deprecated, use '{}' instead",
SnapshotMode.EXPORTED.getValue(), SnapshotMode.INITIAL.getValue());
}
return 0;
})
.withDescription("The criteria for running a snapshot upon startup of the connector. "
+ "Options include: "
+ "'always' to specify that the connector run a snapshot each time it starts up; "

8
debezium-connector-postgres/src/test/java/io/debezium/connector/postgresql/PostgresConnectorIT.java
View File

@ -1518,7 +1518,7 @@ public void shouldAllowForExportedSnapshot() throws Exception {
// the replication slot was created.
TestHelper.execute(SETUP_TABLES_STMT);
Configuration config = TestHelper.defaultConfig()
.with(PostgresConnectorConfig.SNAPSHOT_MODE, SnapshotMode.EXPORTED.getValue())
.with(PostgresConnectorConfig.SNAPSHOT_MODE, SnapshotMode.INITIAL.getValue())
.with(PostgresConnectorConfig.DROP_SLOT_ON_STOP, Boolean.FALSE)
.build();
start(PostgresConnector.class, config);
@ -1552,7 +1552,7 @@ public void shouldAllowForExportedSnapshot() throws Exception {
stopConnector();
config = TestHelper.defaultConfig()
.with(PostgresConnectorConfig.SNAPSHOT_MODE, SnapshotMode.EXPORTED.getValue())
.with(PostgresConnectorConfig.SNAPSHOT_MODE, SnapshotMode.INITIAL.getValue())
.with(PostgresConnectorConfig.DROP_SLOT_ON_STOP, Boolean.TRUE)
.build();
start(PostgresConnector.class, config);
@ -1582,7 +1582,7 @@ public void exportedSnapshotShouldNotSkipRecordOfParallelTx() throws Exception {
TestHelper.execute(INSERT_STMT);
Configuration config = TestHelper.defaultConfig()
.with(PostgresConnectorConfig.SNAPSHOT_MODE, SnapshotMode.EXPORTED.getValue())
.with(PostgresConnectorConfig.SNAPSHOT_MODE, SnapshotMode.INITIAL.getValue())
.with(PostgresConnectorConfig.DROP_SLOT_ON_STOP, Boolean.FALSE)
.with(PostgresConnectorConfig.MAX_QUEUE_SIZE, 2)
.with(PostgresConnectorConfig.MAX_BATCH_SIZE, 1)
@ -1631,7 +1631,7 @@ public void exportedSnapshotShouldNotSkipRecordOfParallelTxPgoutput() throws Exc
TestHelper.execute(INSERT_STMT);
Configuration config = TestHelper.defaultConfig()
.with(PostgresConnectorConfig.SNAPSHOT_MODE, SnapshotMode.EXPORTED.getValue())
.with(PostgresConnectorConfig.SNAPSHOT_MODE, SnapshotMode.INITIAL.getValue())
.with(PostgresConnectorConfig.DROP_SLOT_ON_STOP, Boolean.FALSE)
.with(PostgresConnectorConfig.MAX_QUEUE_SIZE, 2)
.with(PostgresConnectorConfig.MAX_BATCH_SIZE, 1)