prevent netvar changes in replays

leaderboard.lua

@@ -11,6 +11,10 @@ local prevLap = 0
 local splits = {}
 local PATCH = nil
 local help = true
+local EncoreInitial = nil
+
+-- Tracks if stats have been written or not
+local StatTrack = false
 
 local UNCLAIMED = "Unclaimed Record"
 local HELP_MESSAGE = "\x89Leaderboard Commands:\nretry exit findmap changelevel spba_clearcheats lb_gui rival scroll encore"
@@ -28,11 +32,15 @@ local F_SPBJUS = 0x2
 local F_SPBBIG = 0x4
 local F_SPBEXP = 0x8
 
+-- Score table separator
+local ST_SEP = F_SPBATK
+
 local clearcheats = false
 
-local START_TIME = 6 * TICRATE + (3 * TICRATE / 4)
+local START_TIME = 6 * TICRATE + (3 * TICRATE / 4) + 1
 local AFK_TIMEOUT = TICRATE * 5
 local AFK_BALANCE = TICRATE * 60
+local AFK_BALANCE_WARN = AFK_BALANCE - TICRATE * 10
 local PREVENT_JOIN_TIME = START_TIME + TICRATE * 5
 
 local GUI_OFF    = 0x0
@@ -112,25 +120,79 @@ local cv_interrupt = CV_RegisterVar({
 	end
 })
 
+local function setST(t, map, flags, scoreTable)
+	local mode = flags & ST_SEP
+	t[mode] = t[mode] or {}
+	t[mode][map] = scoreTable
+end
+
+local function getST(t, map, flags)
+	local mode = flags & ST_SEP
+	return t[mode] and t[mode][map] or nil
+end
+
 local function setScoreTable(map, flags, scoreTable)
-	local mode = flags & F_SPBATK
+	setST(lb, map, flags, scoreTable)
-	lb[mode] = lb[mode] or {}
-	lb[mode][map] = scoreTable
 end
 
 local function getScoreTable(map, flags)
-	--local id = tostring(map)
+	return getST(lb, map, flags)
-	--if flags & F_SPBATK then
-	--	id = id + "S"
-	--end
-
-	--return id
-
-	local mode = flags & F_SPBATK
-	return lb[mode] and lb[mode][map] or nil
 end
 
-local function score_t(map, name, skin, color, time, splits, flags, restat)
+-- True if a is better than b
+local function lbComp(a, b)
+	-- Calculates the difficulty, harder has higher priority
+	-- if s is positive then a is harder
+	-- if s is negative then b is harder
+	-- if s is 0 then compare time
+	local s = (a["flags"] & (F_SPBEXP | F_SPBBIG)) - (b["flags"] & (F_SPBEXP | F_SPBBIG))
+	return s > 0 or not(s < 0 or a["time"] >= b["time"])
+end
+
+local function sortScores()
+	for mode, t in pairs(lb) do
+		for map, scoreTable in pairs(t) do
+			table.sort(scoreTable, lbComp)
+			setScoreTable(map, mode, scoreTable)
+		end
+	end
+end
+
+-- Reinitialize lb based on new ST_SEP value
+local function reinit_lb()
+	local nlb = {}
+
+	for mode, t in pairs(lb) do
+		for map, scoreTable in pairs(t) do
+			for i, score in ipairs(scoreTable) do
+				local st = getST(nlb, map, score["flags"]) or {}
+				table.insert(st, score)
+				setST(nlb, map, score["flags"], st)
+			end
+		end
+	end
+
+	lb = nlb
+	sortScores()
+end
+
+local cv_spb_separate = CV_RegisterVar({
+	name = "lb_spb_combined",
+	defaultvalue = 1,
+	flags = CV_NETVAR | CV_CALL,
+	PossibleValue = CV_YesNo,
+	func = function(v)
+		if v.value then
+			ST_SEP = F_SPBATK
+		else
+			ST_SEP = F_SPBATK | F_SPBBIG | F_SPBEXP
+		end
+
+		reinit_lb()
+	end
+})
+
+local function score_t(map, name, skin, color, time, splits, flags, stat)
 	return {
 		["map"]    = map,
 		["name"]   = name,
@@ -139,11 +201,11 @@ local function score_t(map, name, skin, color, time, splits, flags, restat)
 		["time"]   = time,
 		["splits"] = splits,
 		["flags"]  = flags,
-		["restat"] = restat
+		["stat"] = stat
 	}
 end
 
-local function restat_t(speed, weight)
+local function stat_t(speed, weight)
 	if speed and weight then
 		return {
 			["speed"] = speed,
@@ -153,9 +215,9 @@ local function restat_t(speed, weight)
 	return nil
 end
 
-local function restat_str(restat)
+local function stat_str(stat)
-	if restat then
+	if stat then
-		return string.format("%d%d", restat["speed"], restat["weight"])
+		return string.format("%d%d", stat["speed"], stat["weight"])
 	end
 
 	return "0"
@@ -166,7 +228,7 @@ local f = io.open(FILENAME, "r")
 if f then
 	for l in f:lines() do
 		-- Leaderboard is stored in the following tab separated format
-		-- mapnum, name, skin, color, time, splits, flags, restat
+		-- mapnum, name, skin, color, time, splits, flags, stat
 		local t = {}
 		for word in (l+"\t"):gmatch("(.-)\t") do
 			table.insert(t, word)
@@ -189,9 +251,9 @@ if f then
 		local stats = nil
 		if t[8] != nil then
 			if #t[8] >= 2 then
-				local speed = string.sub(t[8], 1, 1)
+				local speed = tonumber(string.sub(t[8], 1, 1))
-				local weight = string.sub(t[8], 2, 2)
+				local weight = tonumber(string.sub(t[8], 2, 2))
-				stats = restat_t(speed, weight)
+				stats = stat_t(speed, weight)
 			end
 		end
 
@@ -208,9 +270,11 @@ if f then
 				stats
 			)
 		)
+
 		setScoreTable(tonumber(t[1]), flags, scoreTable)
 	end
 
+	sortScores()
 	f:close()
 else
 	print("Failed to open file: ", FILENAME)
@@ -248,6 +312,13 @@ local function initLeaderboard(player)
 		disable = disable or ingame() > 1
 	end
 	disable = $ or not cv_enable.value
+
+	-- Restore encore mode to initial value
+	if disable and EncoreInitial != nil then
+		COM_BufInsertText(server, string.format("kartencore %d", EncoreInitial))
+		EncoreInitial = nil
+	end
+
 	player.afkTime = leveltime
 end
 addHook("PlayerSpawn", initLeaderboard)
@@ -364,6 +435,10 @@ local function toggleEncore(player)
 	end
 
 	local enc = CV_FindVar("kartencore")
+	if EncoreInitial == nil then
+		EncoreInitial = enc.value
+	end
+
 	if enc.value then
 		COM_BufInsertText(server, "kartencore off")
 	else
@@ -463,13 +538,17 @@ local function findRival(player, ...)
 		return a["rival"]["map"] < b["rival"]["map"]
 	end
 
+	local modestrings = {
+		[F_SPBEXP] = "X",
+		[F_SPBBIG] = "B",
+		[F_SPBJUS] = "J",
+	}
+
 	for mode, tbl in pairs(scores) do
 		if i >= stop then break end
 
 		table.sort(tbl, sortf)
 
-		local spb = mode & F_SPBATK and "SPB" or "TA"
-
 		for _, score in ipairs(tbl) do
 			if o then
 				o = o - 1
@@ -478,6 +557,16 @@ local function findRival(player, ...)
 			if i >= stop then break end
 			i = i + 1
 
+			local modestr = "TA"
+			if score["rival"]["flags"] & F_SPBATK then
+				modestr = "SPB"
+				for k, v in pairs(modestrings) do
+					if score["rival"]["flags"] & k then
+						modestr = $ + v
+					end
+				end
+			end
+
 			if score["your"] then
 				local diff = score["your"]["time"] - score["rival"]["time"]
 				local color = colors[clamp(-1, diff, 1)]
@@ -490,7 +579,7 @@ local function findRival(player, ...)
 						ticsToTime(score["rival"]["time"]),
 						color,
 						sym[diff<0] + ticsToTime(abs(diff)),
-						spb
+						modestr
 					)
 				)
 			else
@@ -501,7 +590,7 @@ local function findRival(player, ...)
 						G_BuildMapName(score["rival"]["map"]),
 						ticsToTime(score["rival"]["time"]),
 						ticsToTime(0, true),
-						spb
+						modestr
 					)
 				)
 			end
@@ -590,6 +679,20 @@ local function drawitem(v, x, y, scale, itempatch, vflags)
 	)
 end
 
+local modePatches = {
+	[F_SPBATK] = "SPB",
+	[F_SPBJUS] = "HYUD",
+	[F_SPBBIG] = "BIG",
+	[F_SPBEXP] = "INV"
+}
+
+local function modePatch(flag)
+	if flag == F_SPBEXP then
+		return PATCH[modePatches[flag]][(leveltime / 4) % 6]
+	end
+	return PATCH[modePatches[flag]]
+end
+
 local cursors = {
 	[1] = ". ",
 	[2] = " ."
@@ -663,7 +766,7 @@ local function drawScore(v, player, pos, x, y, gui, faceRank, score, drawPos, te
 			x - 2,
 			y - 2,
 			scale,
-			PATCH["SPB"],
+			modePatch(F_SPBATK),
 			V_HUDTRANS | VFLAGS
 		)
 		if score["flags"] & F_SPBEXP then
@@ -672,7 +775,7 @@ local function drawScore(v, player, pos, x, y, gui, faceRank, score, drawPos, te
 				x + FACERANK_DIM - 4,
 				y - 2,
 				scale,
-				PATCH["INV"][(leveltime / 4) % 6],
+				modePatch(F_SPBEXP),
 				V_HUDTRANS | VFLAGS
 			)
 		end
@@ -682,7 +785,7 @@ local function drawScore(v, player, pos, x, y, gui, faceRank, score, drawPos, te
 				x - 2,
 				y + FACERANK_DIM - 4,
 				scale,
-				PATCH["BIG"],
+				modePatch(F_SPBBIG),
 				V_HUDTRANS | VFLAGS
 			)
 		end
@@ -692,7 +795,7 @@ local function drawScore(v, player, pos, x, y, gui, faceRank, score, drawPos, te
 				x + FACERANK_DIM - 4,
 				y + FACERANK_DIM - 4,
 				scale,
-				PATCH["HYUD"],
+				modePatch(F_SPBJUS),
 				V_HUDTRANS | VFLAGS
 			)
 		end
@@ -703,15 +806,18 @@ local function drawScore(v, player, pos, x, y, gui, faceRank, score, drawPos, te
 		v.drawNum(x, y + 3, pos, textVFlags | VFLAGS)
 	end
 
-	-- Restats
+	-- Stats
-	local restat = score["restat"]
+	local stat = score["stat"]
-	if restat then
+	local pskin = score["skin"] and skins[score["skin"]]
-		v.drawString(x + FACERANK_DIM - 2, y + 4, restat["speed"], V_HUDTRANS | VFLAGS, "small")
+	if stat and not (
-		v.drawString(x + FACERANK_DIM - 2, y + 8, restat["weight"], V_HUDTRANS | VFLAGS, "small")
+			pskin
+			and pskin.kartweight == stat["weight"]
+			and pskin.kartspeed == stat["speed"]
+		) then
+		v.drawString(x + FACERANK_DIM - 2, y + 4, stat["speed"], V_HUDTRANS | VFLAGS, "small")
+		v.drawString(x + FACERANK_DIM - 2, y + 8, stat["weight"], V_HUDTRANS | VFLAGS, "small")
 	end
 
-	
-	
 	if gui == GUI_ON or (gui == GUI_SPLITS and showSplit) then
 		local name = score["name"]
 
@@ -841,6 +947,14 @@ local stateFunctions = {
 	[DS_SCRLTO] = drawScrollTo
 }
 
+-- Draw mode and return pos + 1 if success
+local function drawMode(v, pos, flag)
+	if not (Flags & flag) then return pos end
+
+	drawitem(v, pos * 6 + 1, 194, FRACUNIT / 4, modePatch(flag), V_SNAPTOBOTTOM | V_SNAPTOLEFT)
+	return pos + 1
+end
+
 local function drawScoreboard(v, player)
 	if disable then return end
 	if player != displayplayers[0] then return end
@@ -857,6 +971,12 @@ local function drawScoreboard(v, player)
 	if gui then
 		stateFunctions[drawState](v, player, scoreTable, gui)
 	end
+
+	local pos = 0
+	-- Draw current active modes bottom left
+	pos = drawMode(v, pos, F_SPBJUS)
+	pos = drawMode(v, pos, F_SPBBIG)
+	pos = drawMode(v, pos, F_SPBEXP)
 end
 hud.add(drawScoreboard, "game")
 
@@ -887,16 +1007,6 @@ function cachePatches(v)
 	end
 end
 
--- True if a is better than b
-local function lbComp(a, b)
-	-- Calculates the difficulty, harder has higher priority
-	-- if s is positive then a is harder
-	-- if s is negative then b is harder
-	-- if s is 0 then compare time
-	local s = (a["flags"] & (F_SPBEXP | F_SPBBIG)) - (b["flags"] & (F_SPBEXP | F_SPBBIG))
-	return s > 0 or not(s < 0 or a["time"] >= b["time"])
-end
-
 -- Find location of player and scroll to it
 function scroll_to(player)
 	local m = getScoreTable(gamemap, Flags) or {}
@@ -912,9 +1022,25 @@ function scroll_to(player)
 	drawState = DS_SCRLTO
 end
 
+-- Write skin stats to each score where there are none
+local function writeStats()
+	for _, t in pairs(lb) do
+		for _, scoreTable in pairs(t) do
+			for _, score in ipairs(scoreTable) do
+				local skin = skins[score["skin"]]
+				if skin and not score["stat"] then
+					local stats = stat_t(skin.kartspeed, skin.kartweight)
+					score["stat"] = stats
+				end
+			end
+		end
+	end
+end
+
 local function saveTime(player)
 	local scoreTable = getScoreTable(gamemap, Flags) or {}
 
+	local pskin = skins[player.mo.skin]
 	local newscore = score_t(
 		gamemap,
 		player.name,
@@ -923,7 +1049,7 @@ local function saveTime(player)
 		timeFinished,
 		splits,
 		Flags,
-		restat_t(player.HMRs, player.HMRw)
+		stat_t(player.HMRs or pskin.kartspeed, player.HMRw or pskin.kartweight)
 	)
 
 	-- Check if you beat your previous best
@@ -957,6 +1083,11 @@ local function saveTime(player)
 
 	setScoreTable(gamemap, Flags, scoreTable)
 
+	if not StatTrack then
+		writeStats()
+		StatTrack = true
+	end
+
 	local f = assert(io.open(FILENAME, "w"))
 	if f == nil then
 		print("Failed to open file for writing: " + FILENAME)
@@ -974,7 +1105,7 @@ local function saveTime(player)
 					score["time"], "\t",
 					table.concat(score["splits"], " "), "\t",
 					score["flags"], "\t",
-					restat_str(score["restat"]), "\n"
+					stat_str(score["stat"]), "\n"
 				)
 			end
 		end
@@ -1020,6 +1151,12 @@ local function think()
 					if p.cmd.buttons then
 						p.afkTime = leveltime
 					end
+
+					--Away from kart
+					if p.afkTime + AFK_BALANCE_WARN == leveltime then
+						chatprintf(p, "[AFK] \x89You will be moved to spectator in 10 seconds!", false)
+						S_StartSound(nil, 26, p)
+					end
 					if p.afkTime + AFK_BALANCE < leveltime then
 						p.spectator = true
 						chatprint("\x89" + p.name + " was moved to the other team for game balance", true)
@@ -1127,13 +1264,15 @@ local function think()
 			p.afkTime = leveltime
 		end
 
-		if leveltime > PREVENT_JOIN_TIME and p.afkTime + AFK_TIMEOUT > leveltime then
+		if not replayplayback then
-			if cv_teamchange.value then
+			if leveltime > PREVENT_JOIN_TIME and p.afkTime + AFK_TIMEOUT > leveltime then
-				allowJoin(false)
+				if cv_teamchange.value then
-			end
+					allowJoin(false)
-		elseif p.afkTime + AFK_TIMEOUT < leveltime then
+				end
-			if not cv_teamchange.value then
+			elseif p.afkTime + AFK_TIMEOUT < leveltime then
-				allowJoin(true)
+				if not cv_teamchange.value then
+					allowJoin(true)
+				end
 			end
 		end
 
@@ -1165,9 +1304,12 @@ function clamp(min_v, v, max_v)
 end
 
 local function netvars(net)
-	lb = net($)
+	Flags = net($)
 	splits = net($)
 	prevLap = net($)
 	drawState = net($)
+	StatTrack = net($)
+	EncoreInitial = net($)
+	lb = net($)
 end
 addHook("NetVars", netvars)