470486104/Server
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
42782589e0
Server/project/src
History
phrisk 42782589e0 Return after returning player offers to avoid redundant remove offer following (!237) 
#### Summary

> Should fix [Issue 523](https://dev.sp-tarkov.com/SPT-AKI/Issues/issues/523)

Tested a few different scenarios and the items were always correctly removed and returned to the player, however I did see the console warnings reported in the issue.

Both of the following call `this.ragfairOfferHandler.removeOffer(...)`:

 - `this.returnPlayerOffer(...)`
 - `this.removeOfferById(...)`

The latter logs a warning to the console because the offer is already removed when we reach that point.

This fix simply returns after the offer has been returned to the player, letting `returnPlayerOffer` deal with removing from the flea

Co-authored-by: phrisk <phrisk@phrisk.com>
Reviewed-on: https://dev.sp-tarkov.com/SPT-AKI/Server/pulls/237
Co-authored-by: phrisk <phrisk@noreply.dev.sp-tarkov.com>
Co-committed-by: phrisk <phrisk@noreply.dev.sp-tarkov.com>
2024-02-27 23:45:47 +00:00
..
callbacks Add maxPatrolValue route for module to pull data from. Added sandboxMaxPatrolvalue to location.json. linting on location.json 2024-02-16 16:17:55 +00:00
context Formatting 2024-02-02 15:00:21 -05:00
controllers only show Found x insurance packages in profile in console, not log file 2024-02-26 18:24:45 +00:00
di EXPERIMENTAL - pass output object into handleItemEvent and into move function 2024-02-10 15:44:21 +00:00
generators Fixed ammobox breaking client + profile due to ragfair refresh adding extra ammo to ammo boxes 2024-02-26 16:32:56 +00:00
helpers updated setFindInRaidStatusForItem() to be protected + added return type 2024-02-27 12:12:46 +00:00
ide Import path alias on the whole project (!157) 2023-10-19 17:21:17 +00:00
loaders Fixes Linting Issues 2024-02-02 15:00:21 -05:00
models Add ability to insert stash rows to profile 2024-02-26 23:51:45 +00:00
routers Add maxPatrolValue route for module to pull data from. Added sandboxMaxPatrolvalue to location.json. linting on location.json 2024-02-16 16:17:55 +00:00
servers Adjustments to profile saving logging logic 2024-02-10 10:07:40 +00:00
services Return after returning player offers to avoid redundant remove offer following (!237) 2024-02-27 23:45:47 +00:00
utils Format draw() 2024-02-20 09:12:16 +00:00
ErrorHandler.ts Formatting/Linting Changes (!168) 2023-11-16 21:42:06 +00:00
Program.ts Formatting/Linting Changes (!168) 2023-11-16 21:42:06 +00:00