470486104/Server
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix InventoryHelper.canPlaceItemInContainer being backwards (!367)

Browse Source 
For whatever reason, `InventoryHelper.canPlaceItemInContainer()` currently returns:
`true` if the item CANNOT be placed in the container
`undefined` if the item CAN be placed
`false` if the function thought it could but then failed when trying to (never happens?)

This didn't cause problems because the only two places that call it also treat the return value backwards - both of which are also fixed in this PR.

Reviewed-on: https://dev.sp-tarkov.com/SPT/Server/pulls/367
Co-authored-by: Tyfon <tyfon7@outlook.com>
Co-committed-by: Tyfon <tyfon7@outlook.com>
This commit is contained in:
Tyfon 2024-07-02 22:05:32 +00:00 committed by chomp
parent 32fc93592a
commit e58ddac0cc
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
project/src/helpers/InventoryHelper.ts
View File

@ -232,7 +232,7 @@ export class InventoryHelper
const stashFS2D = this.cloner.clone(this.getStashSlotMap(pmcData, sessionId));
for (const itemWithChildren of itemsWithChildren)
{
if (this.canPlaceItemInContainer(stashFS2D, itemWithChildren))
if (!this.canPlaceItemInContainer(stashFS2D, itemWithChildren))
{
return false;
}
@ -251,7 +251,7 @@ export class InventoryHelper
{
for (const itemWithChildren of itemsWithChildren)
{
if (this.canPlaceItemInContainer(containerFS2D, itemWithChildren))
if (!this.canPlaceItemInContainer(containerFS2D, itemWithChildren))
{
return false;
}
@ -296,10 +296,10 @@ export class InventoryHelper
}
// Success! exit
return;
return true;
}
return true;
return false;
}
/**