470486104/Server
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improvements to calculateFenceStandingChangeFromKillsAsScav() - should properly handle additional rep loss when over 6 fence rep

Browse Source
This commit is contained in:
Dev 2024-02-11 13:03:38 +00:00
parent a1a68b4282
commit da6244e1ac
2 changed files with 31 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
project/src/controllers/InraidController.ts
View File

@ -487,7 +487,7 @@ export class InraidController
let fenceStanding = Number(pmcData.TradersInfo[fenceId].standing); let fenceStanding = Number(pmcData.TradersInfo[fenceId].standing);
this.logger.debug(`pre-raid fence standing: ${fenceStanding}`); this.logger.debug(`pre-raid fence standing: ${fenceStanding}`);
fenceStanding = this.inRaidHelper.calculateFenceStandingChangeFromKills( fenceStanding = this.inRaidHelper.calculateFenceStandingChangeFromKillsAsScav(
fenceStanding, fenceStanding,
offraidData.profile.Stats.Eft.Victims, offraidData.profile.Stats.Eft.Victims,
); );

59
project/src/helpers/InRaidHelper.ts
View File

@ -88,45 +88,44 @@ export class InRaidHelper
* @param victims Array of kills player performed * @param victims Array of kills player performed
* @returns adjusted karma level after kills are taken into account * @returns adjusted karma level after kills are taken into account
*/ */
public calculateFenceStandingChangeFromKills(existingFenceStanding: number, victims: Victim[]): number public calculateFenceStandingChangeFromKillsAsScav(existingFenceStanding: number, victims: Victim[]): number
{ {
// Run callback on every victim, adding up the standings gained/lossed, starting value is existing fence standing // Run callback on every victim, adding up the standings gained/lossed, starting value is existing fence standing
const newFenceStanding = victims.reduce((acc, victim) => let fenceStanding = existingFenceStanding;
for (const victim of victims)
{ {
const standingForKill = this.getFenceStandingChangeForKillAsScav(victim); const standingChangeForKill = this.getFenceStandingChangeForKillAsScav(victim);
const additionalLossForKill = this.getAdditionalLossForKill(fenceStanding, standingChangeForKill);
let additionalReduction = 0; this.logger.warning(`rep change: ${standingChangeForKill} - additional: ${additionalLossForKill}`);
fenceStanding += standingChangeForKill + additionalLossForKill;
// Only subtract (up to) 2 reputation on penalties, not on rewards
if (standingForKill < 0)
{
if (acc >= 6 && acc <= 8)
{
// Reset fence rep to 6 before subtracting penalty
additionalReduction = acc - 6.0;
}
else
{
additionalReduction = 2;
}
} }
if (standingForKill) return fenceStanding;
{
this.logger.warning(`Lost: ${standingForKill} - additional:${additionalReduction}`);
return (acc + standingForKill) - additionalReduction;
} }
this.logger.warning(
this.localisationService.getText("inraid-missing_standing_for_kill", {
victimSide: victim.Side,
victimRole: victim.Role,
}),
);
return acc; protected getAdditionalLossForKill(fenceStanding: number, repChangeForKill: number): number
}, existingFenceStanding); {
// No loss for kill, skip
if (repChangeForKill >= 0)
{
return 0;
}
return newFenceStanding; // Over 8, big penalty
if (fenceStanding > 8)
{
return -2.0;
}
// Fence rep is between 6 and 8, appy additional penalty
if (fenceStanding >= 6)
{
return -1;
}
// No additional penalty
return 0;
} }
/** /**