Fixed issue where server would enter infinite loop when selling item to trader and stash contained no money

project/src/helpers/InventoryHelper.ts

@@ -1305,22 +1305,28 @@ export class InventoryHelper
      */
     public isItemInStash(pmcData: IPmcData, itemToCheck: Item): boolean
     {
-        const container = itemToCheck;
+        // Create recursive helper function
-
+        const isParentInStash = (itemId: string): boolean =>
-        while ("parentId" in container)
         {
-            if (container.parentId === pmcData.Inventory.stash && container.slotId === "hideout")
+            // Item not found / has no parent
+            const item = pmcData.Inventory.items.find((item) => item._id === itemId);
+            if (!item || !item.parentId)
+            {
+                return false;
+            }
+
+            // Root level. Items parent is the stash with slotId "hideout"
+            if (item.parentId === pmcData.Inventory.stash && item.slotId === "hideout")
             {
                 return true;
             }
 
-            if (!pmcData.Inventory.items.some((item) => item._id === container.parentId))
+            // Recursive case: Check the items parent
-            {
+            return isParentInStash(item.parentId);
-                break;
+        };
-            }
-        }
 
-        return false;
+        // Start recursive check
+        return isParentInStash(itemToCheck._id);
     }
 }