470486104/Server
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix daily reward budget not being honored when filtering items (!277)

Browse Source 
Turns out `Array.filter` returns the filtered array, it doesn't modify the passed in array

Co-authored-by: DrakiaXYZ <565558+TheDgtl@users.noreply.github.com>
Reviewed-on: https://dev.sp-tarkov.com/SPT-AKI/Server/pulls/277
Co-authored-by: DrakiaXYZ <drakiaxyz@noreply.dev.sp-tarkov.com>
Co-committed-by: DrakiaXYZ <drakiaxyz@noreply.dev.sp-tarkov.com>
This commit is contained in:
DrakiaXYZ 2024-04-01 08:38:23 +00:00 committed by chomp
parent 7ccb524eea
commit aabd325804
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
project/src/generators/RepeatableQuestRewardGenerator.ts
View File

@ -116,7 +116,7 @@ export class RepeatableQuestRewardGenerator
// Possible improvement -> draw trader-specific items e.g. with this.itemHelper.isOfBaseclass(val._id, ItemHelper.BASECLASS.FoodDrink)
let roublesBudget = rewardRoubles;
const rewardItemPool = this.chooseRewardItemsWithinBudget(repeatableConfig, roublesBudget, traderId);
let rewardItemPool = this.chooseRewardItemsWithinBudget(repeatableConfig, roublesBudget, traderId);
this.logger.debug(
`Generating daily quest for ${traderId} with budget ${roublesBudget} for ${rewardNumItems} items`,
);
@ -213,7 +213,8 @@ export class RepeatableQuestRewardGenerator
if (roublesBudget > 0)
{
// Filter possible reward items to only items with a price below the remaining budget
if (!this.filterRewardPoolWithinBudget(rewardItemPool, roublesBudget, 0))
rewardItemPool = this.filterRewardPoolWithinBudget(rewardItemPool, roublesBudget, 0);
if (rewardItemPool.length === 0)
{
this.logger.debug(` Reward pool empty with ${roublesBudget} remaining`);
break; // No reward items left, exit
@ -269,15 +270,13 @@ export class RepeatableQuestRewardGenerator
rewardItems: ITemplateItem[],
roublesBudget: number,
minPrice: number,
): boolean
): ITemplateItem[]
{
rewardItems.filter((item) =>
return rewardItems.filter((item) =>
{
const itemPrice = this.presetHelper.getDefaultPresetOrItemPrice(item._id);
return itemPrice < roublesBudget && itemPrice > minPrice;
});
return (rewardItems.length > 0);
}
/**
@ -357,7 +356,12 @@ export class RepeatableQuestRewardGenerator
const minPrice = Math.min(25000, 0.5 * roublesBudget);
let rewardableItemPoolWithinBudget = rewardableItemPool.map((x) => x[1]);
if (!this.filterRewardPoolWithinBudget(rewardableItemPoolWithinBudget, roublesBudget, minPrice))
rewardableItemPoolWithinBudget = this.filterRewardPoolWithinBudget(
rewardableItemPoolWithinBudget,
roublesBudget,
minPrice,
);
if (rewardableItemPoolWithinBudget.length === 0)
{
this.logger.warning(
this.localisationService.getText("repeatable-no_reward_item_found_in_price_range", {