470486104/Server
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed achievement counters getting mistakenly cleaned up as stale quest counters (!189)

Browse Source 
Fixes #273

Co-authored-by: Terkoiz <terkoiz@spt.dev>
Reviewed-on: https://dev.sp-tarkov.com/SPT-AKI/Server/pulls/189
Co-authored-by: Terkoiz <terkoiz@noreply.dev.sp-tarkov.com>
Co-committed-by: Terkoiz <terkoiz@noreply.dev.sp-tarkov.com>
This commit is contained in:
Terkoiz 2024-01-09 11:57:27 +00:00 committed by chomp
parent 01e63118c6
commit 98b0a579b3
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
project/src/services/ProfileFixerService.ts
View File

@ -515,15 +515,18 @@ export class ProfileFixerService
{ {
const counterKeysToRemove: string[] = []; const counterKeysToRemove: string[] = [];
const activeQuests = this.getActiveRepeatableQuests(pmcProfile.RepeatableQuests); const activeQuests = this.getActiveRepeatableQuests(pmcProfile.RepeatableQuests);
const achievements = this.databaseServer.getTables().templates.achievements;
for (const [key, backendCounter] of Object.entries(pmcProfile.TaskConditionCounters)) for (const [key, backendCounter] of Object.entries(pmcProfile.TaskConditionCounters))
{ {
if (pmcProfile.RepeatableQuests && activeQuests.length > 0) if (pmcProfile.RepeatableQuests && activeQuests.length > 0)
{ {
const existsInActiveRepeatableQuests = activeQuests.some((x) => x._id === backendCounter.sourceId); const existsInActiveRepeatableQuests = activeQuests.some((x) => x._id === backendCounter.sourceId);
const existsInQuests = pmcProfile.Quests.some((q) => q.qid === backendCounter.sourceId); const existsInQuests = pmcProfile.Quests.some((q) => q.qid === backendCounter.sourceId);
const isAchievementTracker = achievements.some((a) => a.id === backendCounter.sourceId);
// if BackendCounter's quest is neither in activeQuests nor Quests it's stale // if BackendCounter is neither in activeQuests, quests or achievements - it's stale and should be cleaned up
if (!(existsInActiveRepeatableQuests || existsInQuests)) if (!(existsInActiveRepeatableQuests || existsInQuests || isAchievementTracker))
{ {
counterKeysToRemove.push(key); counterKeysToRemove.push(key);
} }