470486104/Server
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rework usage of filter() into some()

Browse Source
This commit is contained in:
Dev 2023-08-07 11:17:46 +01:00
parent 92c30dbe5d
commit 74f7ee8e77
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
project/src/services/ProfileFixerService.ts
View File

@ -220,11 +220,11 @@ export class ProfileFixerService
{ {
if (pmcProfile.RepeatableQuests && activeQuests.length > 0) if (pmcProfile.RepeatableQuests && activeQuests.length > 0)
{ {
const matchingQuest = activeQuests.filter(x => x._id === backendCounter.qid); const existsInActiveRepeatableQuests = activeQuests.some(x => x._id === backendCounter.qid);
const quest = pmcProfile.Quests.filter(q => q.qid === backendCounter.qid); const existsInQuests = pmcProfile.Quests.some(q => q.qid === backendCounter.qid);
// if BackendCounter's quest is neither in activeQuests nor Quests it's stale // if BackendCounter's quest is neither in activeQuests nor Quests it's stale
if (matchingQuest.length === 0 && quest.length === 0) if (existsInActiveRepeatableQuests && existsInQuests)
{ {
counterKeysToRemove.push(key); counterKeysToRemove.push(key);
} }