470486104/Server
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Update moveItem() to better handle when the item being moved has no slotId

Browse Source
This commit is contained in:
Dev 2024-02-12 23:14:04 +00:00
parent c4520ddbe9
commit 6709300e93
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
project/src/controllers/InventoryController.ts
View File

@ -106,8 +106,7 @@ export class InventoryController
} }
// Check for item in inventory before allowing internal transfer // Check for item in inventory before allowing internal transfer
const originalItemLocation = ownerInventoryItems.from.find((x) => x._id === moveRequest.item); const originalItemLocation = ownerInventoryItems.from.find((item) => item._id === moveRequest.item);
const originalLocationSlotId = originalItemLocation.slotId;
if (!originalItemLocation) if (!originalItemLocation)
{ {
// Internal item move but item never existed, possible dupe glitch // Internal item move but item never existed, possible dupe glitch
@ -115,6 +114,8 @@ export class InventoryController
return; return;
} }
const originalLocationSlotId = originalItemLocation?.slotId;
const moveResult = this.inventoryHelper.moveItemInternal(pmcData, ownerInventoryItems.from, moveRequest); const moveResult = this.inventoryHelper.moveItemInternal(pmcData, ownerInventoryItems.from, moveRequest);
if (!moveResult.success) if (!moveResult.success)
{ {
@ -123,7 +124,7 @@ export class InventoryController
} }
// Item is moving into or out of place of fame dogtag slot // Item is moving into or out of place of fame dogtag slot
if (moveRequest.to.container.startsWith("dogtag") || originalLocationSlotId.startsWith("dogtag")) if (moveRequest.to.container.startsWith("dogtag") || originalLocationSlotId?.startsWith("dogtag"))
{ {
this.hideoutHelper.applyPlaceOfFameDogtagBonus(pmcData); this.hideoutHelper.applyPlaceOfFameDogtagBonus(pmcData);
} }