From 5ffedfa91ae86735868b6202d9e0b33bb37ef5e6 Mon Sep 17 00:00:00 2001
From: Dev <dev@dev.sp-tarkov.com>
Date: Sun, 18 Aug 2024 09:52:13 +0100
Subject: [PATCH] Attempted to fix issue with `calculateItemWorth()` failing on
 child items without a upd object Clone children when returned to prevent
 modification + add missing upd object to child before calculating price

---
 project/src/services/RagfairTaxService.ts | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/project/src/services/RagfairTaxService.ts b/project/src/services/RagfairTaxService.ts
index 34ba78c7..896ae2e5 100644
--- a/project/src/services/RagfairTaxService.ts
+++ b/project/src/services/RagfairTaxService.ts
@@ -8,6 +8,7 @@ import { BonusType } from "@spt/models/enums/BonusType";
 import { ILogger } from "@spt/models/spt/utils/ILogger";
 import { DatabaseService } from "@spt/services/DatabaseService";
 import { RagfairPriceService } from "@spt/services/RagfairPriceService";
+import { ICloner } from "@spt/utils/cloners/ICloner";
 import { inject, injectable } from "tsyringe";
 
 @injectable()
@@ -20,6 +21,7 @@ export class RagfairTaxService {
         @inject("RagfairPriceService") protected ragfairPriceService: RagfairPriceService,
         @inject("ItemHelper") protected itemHelper: ItemHelper,
         @inject("ProfileHelper") protected profileHelper: ProfileHelper,
+        @inject("PrimaryCloner") protected cloner: ICloner,
     ) {}
 
     public storeClientOfferTaxValue(sessionId: string, offer: IStorePlayerOfferTaxAmountRequestData): void {
@@ -120,15 +122,20 @@ export class RagfairTaxService {
             // Since we get a flat list of all child items, we only want to recurse from parent item
             const itemChildren = this.itemHelper.findAndReturnChildrenAsItems(pmcData.Inventory.items, item._id);
             if (itemChildren.length > 1) {
-                for (const child of itemChildren) {
+                const itemChildrenClone = this.cloner.clone(itemChildren); // Clone is expensive, only run if necessary
+                for (const child of itemChildrenClone) {
                     if (child._id === item._id) {
                         continue;
                     }
 
+                    if (!child.upd) {
+                        child.upd = {};
+                    }
+
                     worth += this.calculateItemWorth(
                         child,
                         this.itemHelper.getItem(child._tpl)[1],
-                        child.upd?.StackObjectsCount ?? 1,
+                        child.upd.StackObjectsCount ?? 1,
                         pmcData,
                         false,
                     );