Implement TransitItemsDelivery service via expansion of the BTR item delivery handler (!413)

- Fixes exception thrown when attempting to transfer items during transit
- Implements transit item transfer by expanding on the existing BTR item transfer code (They are both BTR services)

Co-authored-by: DrakiaXYZ <565558+TheDgtl@users.noreply.github.com>
Reviewed-on: https://dev.sp-tarkov.com/SPT/Server/pulls/413
Co-authored-by: DrakiaXYZ <drakiaxyz@noreply.dev.sp-tarkov.com>
Co-committed-by: DrakiaXYZ <drakiaxyz@noreply.dev.sp-tarkov.com>

project/assets/database/templates/locationServices.json

@@ -102,6 +102,16 @@
                 },
                 "ServiceItemCost": [],
                 "UniqueItems": []
+            },
+            "TransitItemsDelivery": {
+                "TraderId": "656f0f98d80a697f855d34b1",
+                "TraderServiceType": "TransitItemsDelivery",
+                "Requirements": {
+                    "CompletedQuests": [],
+                    "Standings": []
+                },
+                "ServiceItemCost": [],
+                "UniqueItems": []
             }
         }
     },

project/assets/database/traders/656f0f98d80a697f855d34b1/services.json

@@ -7,5 +7,8 @@
 	},
 	{
 		"serviceType": "BtrBotCover"
-	}
+	},
+    {
+        "serviceType": "TransitItemsDelivery"
+    }
 ]

project/src/models/enums/TraderServiceType.ts

@@ -5,4 +5,5 @@ export enum TraderServiceType {
     BTR_ITEMS_DELIVERY = "BtrItemsDelivery",
     PLAYER_TAXI = "PlayerTaxi",
     BTR_BOT_COVER = "BtrBotCover",
+    TRANSIT_ITEMS_DELIVERY = "TransitItemsDelivery",
 }

project/src/services/LocationLifecycleService.ts

@@ -311,10 +311,8 @@ export class LocationLifecycleService {
         const isDead = this.isPlayerDead(request.results);
         const isSurvived = this.isPlayerSurvived(request.results);
 
-        // Handle items transferred via BTR to player
+        // Handle items transferred via BTR or transit to player
-        this.handleBTRItemTransferEvent(sessionId, request);
+        this.handleItemTransferEvent(sessionId, request);
-
-        this.handleTransitItemTransferEvent(sessionId, request);
 
         if (!isPmc) {
             this.handlePostRaidPlayerScav(sessionId, pmcProfile, scavProfile, isDead, request);
@@ -688,23 +686,28 @@ export class LocationLifecycleService {
     }
 
     /**
-     * Check if player used BTR item sending service and send items to player via mail if found
+     * Check if player used BTR or transit item sending service and send items to player via mail if found
      * @param sessionId Session id
      * @param request End raid request
      */
-    protected handleBTRItemTransferEvent(sessionId: string, request: IEndLocalRaidRequestData): void {
+    protected handleItemTransferEvent(sessionId: string, request: IEndLocalRaidRequestData): void {
-        const btrId = `${Traders.BTR}_btr`;
+        const transferTypes = ["btr", "transit"];
-        let itemsToSend = request.transferItems[btrId] ?? [];
-        if (itemsToSend.length === 0) {
-            return;
-        }
 
-        // Filter out the btr container item from transferred items before delivering
+        for (const trasferType of transferTypes) {
-        itemsToSend = itemsToSend.filter((item) => item._id !== btrId);
+            const rootId = `${Traders.BTR}_${trasferType}`;
-        this.btrItemDelivery(sessionId, Traders.BTR, itemsToSend);
+            let itemsToSend = request.transferItems[rootId] ?? [];
+
+            // Filter out the btr container item from transferred items before delivering
+            itemsToSend = itemsToSend.filter((item) => item._id !== Traders.BTR);
+            if (itemsToSend.length === 0) {
+                continue;
+            }
+
+            this.transferItemDelivery(sessionId, Traders.BTR, itemsToSend);
+        }
     }
 
-    protected btrItemDelivery(sessionId: string, traderId: string, items: IItem[]): void {
+    protected transferItemDelivery(sessionId: string, traderId: string, items: IItem[]): void {
         const serverProfile = this.saveServer.getProfile(sessionId);
         const pmcData = serverProfile.characters.pmc;
 
@@ -737,18 +740,6 @@ export class LocationLifecycleService {
         );
     }
 
-    protected handleTransitItemTransferEvent(sessionId: string, request: IEndLocalRaidRequestData) {
-        const id = "TODO_DUMP";
-        const transitRootId = `${id}_transit`;
-        const itemsToSend = request.transferItems[transitRootId] ?? [];
-        if (itemsToSend.length === 0) {
-            this.logger.error("NOT IMPLEMENTED");
-            return;
-        }
-
-        this.logger.error("NOT IMPLEMENTED");
-    }
-
     protected handleInsuredItemLostEvent(
         sessionId: string,
         preRaidPmcProfile: IPmcData,