470486104/Server
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Nullguard removeQuestFromScavProfile() accessing a null scav quest array

Browse Source
This commit is contained in:
Dev 2023-11-10 19:13:14 +00:00
parent 7849a730f2
commit 37029791da
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
project/src/controllers/QuestController.ts
View File

@ -498,10 +498,10 @@ export class QuestController
protected removeQuestFromScavProfile(sessionId: string, questIdToRemove: string): void protected removeQuestFromScavProfile(sessionId: string, questIdToRemove: string): void
{ {
const fullProfile = this.profileHelper.getFullProfile(sessionId); const fullProfile = this.profileHelper.getFullProfile(sessionId);
const repeatableInScavProfile = fullProfile.characters.scav.Quests.find(x => x.qid === questIdToRemove); const repeatableInScavProfile = fullProfile.characters.scav.Quests?.find(x => x.qid === questIdToRemove);
if (!repeatableInScavProfile) if (!repeatableInScavProfile)
{ {
this.logger.warning(`Unable to remove quest: ${questIdToRemove} from profile as scav profile cannot be found`); this.logger.warning(`Unable to remove quest: ${questIdToRemove} from profile as scav quest cannot be found`);
return; return;
} }