470486104/Server
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve comments of getQuestsFailedByCompletingQuest()

Browse Source
This commit is contained in:
Dev 2024-01-05 22:59:01 +00:00
parent 9fb747f5f6
commit 2de4164a93
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
project/src/controllers/QuestController.ts
View File

@ -675,22 +675,22 @@ export class QuestController
} }
/** /**
* Returns a list of quests that should be failed when a quest is completed * Return a list of quests that would fail when supplied quest is completed
* @param completedQuestId quest completed id * @param completedQuestId quest completed id
* @returns array of quests * @returns array of IQuest objects
*/ */
protected getQuestsFailedByCompletingQuest(completedQuestId: string): IQuest[] protected getQuestsFailedByCompletingQuest(completedQuestId: string): IQuest[]
{ {
const questsInDb = this.questHelper.getQuestsFromDb(); const questsInDb = this.questHelper.getQuestsFromDb();
return questsInDb.filter((x) => return questsInDb.filter((quest) =>
{ {
// No fail conditions, exit early // No fail conditions, exit early
if (!x.conditions.Fail || x.conditions.Fail.length === 0) if (!quest.conditions.Fail || quest.conditions.Fail.length === 0)
{ {
return false; return false;
} }
return x.conditions.Fail.some((y) => y.target?.includes(completedQuestId)); return quest.conditions.Fail.some((condition) => condition.target?.includes(completedQuestId));
}); });
} }