Fix issue with generating event bots not being cached under the correct name

Dont get bot from cache after generating it. Its popping bot off end of array only to be discarded
This commit is contained in:
Dev 2024-03-14 22:14:00 +00:00
parent e4d81b43b6
commit 2af3ca9ff5

View File

@ -214,14 +214,13 @@ export class BotController
} }
// Loop over and make x bots for this bot wave // Loop over and make x bots for this bot wave
let cacheKey = ""; const cacheKey = `${
botGenerationDetails.eventRole ?? botGenerationDetails.role
}${botGenerationDetails.botDifficulty}`;
for (let i = 0; i < botGenerationDetails.botCountToGenerate; i++) for (let i = 0; i < botGenerationDetails.botCountToGenerate; i++)
{ {
const detailsClone = this.jsonUtil.clone(botGenerationDetails);
cacheKey = `${detailsClone.role}${detailsClone.botDifficulty}`;
// Generate and add bot to cache // Generate and add bot to cache
const detailsClone = this.jsonUtil.clone(botGenerationDetails);
const botToCache = this.botGenerator.prepareAndGenerateBot(sessionId, detailsClone); const botToCache = this.botGenerator.prepareAndGenerateBot(sessionId, detailsClone);
this.botGenerationCacheService.storeBots(cacheKey, [botToCache]); this.botGenerationCacheService.storeBots(cacheKey, [botToCache]);
} }
@ -231,9 +230,6 @@ export class BotController
botGenerationDetails.eventRole ?? "" botGenerationDetails.eventRole ?? ""
}) ${botGenerationDetails.botDifficulty} bots`, }) ${botGenerationDetails.botDifficulty} bots`,
); );
// Get bot from cache, add to return array
const botToReturn = this.botGenerationCacheService.getBot(cacheKey);
} }
return []; return [];