470486104/Server
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed off by one error inside generateUniqueBotNickname that would result in undefined names when the unique name pool was low

Browse Source
This commit is contained in:
Dev 2024-09-30 16:55:34 +01:00
parent 9d55bf0fac
commit 24ab327ac2
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
project/src/services/BotNameService.ts
View File

@ -60,7 +60,7 @@ export class BotNameService {
let isUnique = true; let isUnique = true;
let attempts = 0; let attempts = 0;
while (attempts < 5) { while (attempts <= 5) {
const isPlayerScav = botGenerationDetails.isPlayerScav; const isPlayerScav = botGenerationDetails.isPlayerScav;
const simulateScavName = isPlayerScav ? false : this.shouldSimulatePlayerScavName(botRole); const simulateScavName = isPlayerScav ? false : this.shouldSimulatePlayerScavName(botRole);
@ -93,7 +93,11 @@ export class BotNameService {
// Not unique // Not unique
if (attempts >= 5) { if (attempts >= 5) {
// 5 attempts to generate a name, pool probably isn't big enough // 5 attempts to generate a name, pool probably isn't big enough
this.logger.debug(`Failed to find unique name for: ${name} after 5 attempts`); const genericName = `${botGenerationDetails.side} ${this.randomUtil.getInt(100000, 999999)}`;
this.logger.debug(
`Failed to find unique name for: ${name} after 5 attempts, using: ${genericName}`,
);
return genericName;
} }
attempts++; attempts++;