470486104/Server
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Change name of trainArrivalDelaySeconds to clarify its meaning (!171)

Browse Source 
Changed the name of the new `trainArrivalDelaySeconds` setting to `trainArrivalDelayObservedSeconds` so it's more obvious that it doesn't actually control the train arrival time.

`trainArrivalDelayObservedSeconds` is my first choice for naming this setting, and `trainArrivalDelayThatYouDefinitelyShouldNotChangeSoDoNotEvenThinkAboutItSeconds` is my second choice.

Co-authored-by: dwesterwick <dwesterwick@yahoo.com>
Reviewed-on: https://dev.sp-tarkov.com/SPT-AKI/Server/pulls/171
Co-authored-by: DanW <danw@noreply.dev.sp-tarkov.com>
Co-committed-by: DanW <danw@noreply.dev.sp-tarkov.com>
This commit is contained in:
DanW 2023-12-02 19:41:27 +00:00 committed by chomp
parent f5e5136603
commit 1fdd1967e9
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
project/assets/configs/location.json
View File

@ -842,7 +842,7 @@
"looseLootBlacklist": {}, "looseLootBlacklist": {},
"scavRaidTimeSettings": { "scavRaidTimeSettings": {
"settings": { "settings": {
"trainArrivalDelaySeconds": 90 "trainArrivalDelayObservedSeconds": 90
}, },
"maps": { "maps": {
"bigmap": { "bigmap": {

2
project/src/models/spt/config/ILocationConfig.ts
View File

@ -115,7 +115,7 @@ export interface IScavRaidTimeSettings
export interface IScavRaidTimeConfigSettings export interface IScavRaidTimeConfigSettings
{ {
trainArrivalDelaySeconds: number trainArrivalDelayObservedSeconds: number
} }
export interface IScavRaidTimeLocationSettings export interface IScavRaidTimeLocationSettings

2
project/src/services/RaidTimeAdjustmentService.ts
View File

@ -226,7 +226,7 @@ export class RaidTimeAdjustmentService
// //
// I added 2 seconds just to be safe... // I added 2 seconds just to be safe...
// //
const trainArrivalDelaySeconds = this.locationConfig.scavRaidTimeSettings.settings.trainArrivalDelaySeconds; const trainArrivalDelaySeconds = this.locationConfig.scavRaidTimeSettings.settings.trainArrivalDelayObservedSeconds;
// Determine the earliest possible time in the raid when the train would leave // Determine the earliest possible time in the raid when the train would leave
const earliestPossibleDepartureMinutes = (exit.MinTime + exit.Count + exit.ExfiltrationTime + trainArrivalDelaySeconds) / 60; const earliestPossibleDepartureMinutes = (exit.MinTime + exit.Count + exit.ExfiltrationTime + trainArrivalDelaySeconds) / 60;